Nameing fixes

pull/1530/head
Ellet 1 year ago
parent 1611fa0aac
commit e729683abe
No known key found for this signature in database
GPG Key ID: C488CC70BBCEF0D1
  1. 6
      flutter_quill_extensions/lib/presentation/embeds/editor/video/video.dart
  2. 2
      flutter_quill_extensions/lib/presentation/embeds/widgets/image_resizer.dart
  3. 33
      flutter_quill_extensions/lib/presentation/embeds/widgets/simple_dialog_item.dart
  4. 24
      flutter_quill_extensions/lib/presentation/embeds/widgets/youtube_video_app.dart
  5. 24
      flutter_quill_extensions/lib/presentation/utils/utils.dart

@ -37,10 +37,10 @@ class QuillEditorVideoEmbedBuilder extends EmbedBuilder {
readOnly: readOnly, readOnly: readOnly,
); );
} }
final ((imageSize), margin, alignment) = getElementAttributes(node); final ((elementSize), margin, alignment) = getElementAttributes(node);
final width = imageSize.width; final width = elementSize.width;
final height = imageSize.height; final height = elementSize.height;
return Container( return Container(
width: width, width: width,
height: height, height: height,

@ -20,7 +20,7 @@ class ImageResizer extends StatefulWidget {
final double? imageHeight; final double? imageHeight;
final double maxWidth; final double maxWidth;
final double maxHeight; final double maxHeight;
final Function(double, double) onImageResize; final Function(double width, double height) onImageResize;
@override @override
ImageResizerState createState() => ImageResizerState(); ImageResizerState createState() => ImageResizerState();

@ -1,33 +0,0 @@
import 'package:flutter/material.dart';
class SimpleDialogItem extends StatelessWidget {
const SimpleDialogItem({
required this.icon,
required this.color,
required this.text,
required this.onPressed,
super.key,
});
final IconData icon;
final Color color;
final String text;
final VoidCallback onPressed;
@override
Widget build(BuildContext context) {
return SimpleDialogOption(
onPressed: onPressed,
child: Row(
children: [
Icon(icon, size: 36, color: color),
Padding(
padding: const EdgeInsetsDirectional.only(start: 16),
child:
Text(text, style: const TextStyle(fontWeight: FontWeight.bold)),
),
],
),
);
}
}

@ -1,7 +1,7 @@
import 'package:flutter/gestures.dart'; import 'package:flutter/gestures.dart' show TapGestureRecognizer;
import 'package:flutter/material.dart'; import 'package:flutter/widgets.dart';
import 'package:flutter_quill/flutter_quill.dart'; import 'package:flutter_quill/flutter_quill.dart' show DefaultStyles;
import 'package:url_launcher/url_launcher.dart'; import 'package:url_launcher/url_launcher.dart' show launchUrl;
import 'package:youtube_player_flutter/youtube_player_flutter.dart'; import 'package:youtube_player_flutter/youtube_player_flutter.dart';
class YoutubeVideoApp extends StatefulWidget { class YoutubeVideoApp extends StatefulWidget {
@ -45,15 +45,19 @@ class YoutubeVideoAppState extends State<YoutubeVideoApp> {
if (widget.readOnly) { if (widget.readOnly) {
return RichText( return RichText(
text: TextSpan( text: TextSpan(
text: widget.videoUrl, text: widget.videoUrl,
style: defaultStyles.link, style: defaultStyles.link,
recognizer: TapGestureRecognizer() recognizer: TapGestureRecognizer()
..onTap = () => launchUrl(Uri.parse(widget.videoUrl))), ..onTap = () => launchUrl(
Uri.parse(widget.videoUrl),
),
),
); );
} }
return RichText( return RichText(
text: TextSpan(text: widget.videoUrl, style: defaultStyles.link)); text: TextSpan(text: widget.videoUrl, style: defaultStyles.link),
);
} }
return SizedBox( return SizedBox(
@ -78,7 +82,7 @@ class YoutubeVideoAppState extends State<YoutubeVideoApp> {
@override @override
void dispose() { void dispose() {
super.dispose();
_youtubeController?.dispose(); _youtubeController?.dispose();
super.dispose();
} }
} }

@ -92,15 +92,15 @@ Future<SaveImageResult> saveImage({
} }
( (
OptionalSize imageSize, OptionalSize elementSize,
double? margin, double? margin,
Alignment alignment, Alignment alignment,
) getElementAttributes( ) getElementAttributes(
Node node, Node node,
) { ) {
var imageSize = const OptionalSize(null, null); var elementSize = const OptionalSize(null, null);
var imageAlignment = Alignment.center; var elementAlignment = Alignment.center;
double? imageMargin; double? elementMargin;
// Usually double value // Usually double value
final heightValue = double.tryParse( final heightValue = double.tryParse(
@ -109,12 +109,12 @@ Future<SaveImageResult> saveImage({
node.style.attributes[Attribute.width.key]?.value.toString() ?? ''); node.style.attributes[Attribute.width.key]?.value.toString() ?? '');
if (heightValue != null) { if (heightValue != null) {
imageSize = imageSize.copyWith( elementSize = elementSize.copyWith(
height: heightValue, height: heightValue,
); );
} }
if (widthValue != null) { if (widthValue != null) {
imageSize = imageSize.copyWith( elementSize = elementSize.copyWith(
width: widthValue, width: widthValue,
); );
} }
@ -136,7 +136,7 @@ Future<SaveImageResult> saveImage({
'alignment', 'alignment',
}); });
if (attrs.isEmpty) { if (attrs.isEmpty) {
return (imageSize, imageMargin, imageAlignment); return (elementSize, elementMargin, elementAlignment);
} }
// It css value as string but we will try to support it anyway // It css value as string but we will try to support it anyway
@ -154,24 +154,24 @@ Future<SaveImageResult> saveImage({
.replaceFirst('px', '')); .replaceFirst('px', ''));
if (cssHeightValue != null) { if (cssHeightValue != null) {
imageSize = imageSize.copyWith(height: cssHeightValue); elementSize = elementSize.copyWith(height: cssHeightValue);
} }
if (cssWidthValue != null) { if (cssWidthValue != null) {
imageSize = imageSize.copyWith(width: cssWidthValue); elementSize = elementSize.copyWith(width: cssWidthValue);
} }
imageAlignment = base.getAlignment(base.isMobile(supportWeb: false) elementAlignment = base.getAlignment(base.isMobile(supportWeb: false)
? attrs[AttributeExt.mobileAlignment.key] ? attrs[AttributeExt.mobileAlignment.key]
: attrs['alignment']); : attrs['alignment']);
final margin = (base.isMobile(supportWeb: false) final margin = (base.isMobile(supportWeb: false)
? double.tryParse(AttributeExt.mobileMargin.key) ? double.tryParse(AttributeExt.mobileMargin.key)
: double.tryParse('margin')); : double.tryParse('margin'));
if (margin != null) { if (margin != null) {
imageMargin = margin; elementMargin = margin;
} }
} }
return (imageSize, imageMargin, imageAlignment); return (elementSize, elementMargin, elementAlignment);
} }
@immutable @immutable

Loading…
Cancel
Save