From df3afd3f37bf3e1b7124fb2b8f7292f7d8e6bdc0 Mon Sep 17 00:00:00 2001 From: MacDeveloper1 <130981115+MacDeveloper1@users.noreply.github.com> Date: Wed, 24 May 2023 15:56:19 +0200 Subject: [PATCH] Fix PR #1230 (#1233) --- example/lib/pages/home_page.dart | 1 + example/lib/universal_ui/universal_ui.dart | 2 ++ flutter_quill_extensions/CHANGELOG.md | 3 +++ flutter_quill_extensions/lib/embeds/builders.dart | 4 ++++ flutter_quill_extensions/pubspec.yaml | 4 ++-- 5 files changed, 12 insertions(+), 2 deletions(-) diff --git a/example/lib/pages/home_page.dart b/example/lib/pages/home_page.dart index 40449aeb..11baf428 100644 --- a/example/lib/pages/home_page.dart +++ b/example/lib/pages/home_page.dart @@ -502,6 +502,7 @@ class NotesEmbedBuilder extends EmbedBuilder { Embed node, bool readOnly, bool inline, + TextStyle textStyle, ) { final notes = NotesBlockEmbed(node.value.data).document; diff --git a/example/lib/universal_ui/universal_ui.dart b/example/lib/universal_ui/universal_ui.dart index 7b35f1f1..91344afb 100644 --- a/example/lib/universal_ui/universal_ui.dart +++ b/example/lib/universal_ui/universal_ui.dart @@ -38,6 +38,7 @@ class ImageEmbedBuilderWeb extends EmbedBuilder { Embed node, bool readOnly, bool inline, + TextStyle textStyle, ) { final imageUrl = node.value.data; if (isImageBase64(imageUrl)) { @@ -80,6 +81,7 @@ class VideoEmbedBuilderWeb extends EmbedBuilder { Embed node, bool readOnly, bool inline, + TextStyle textStyle, ) { var videoUrl = node.value.data; if (videoUrl.contains('youtube.com') || videoUrl.contains('youtu.be')) { diff --git a/flutter_quill_extensions/CHANGELOG.md b/flutter_quill_extensions/CHANGELOG.md index 3bb1abe4..176876c7 100644 --- a/flutter_quill_extensions/CHANGELOG.md +++ b/flutter_quill_extensions/CHANGELOG.md @@ -1,3 +1,6 @@ +## 0.3.3 +* Fix a prototype bug which was bring by [PR #1230](https://github.com/singerdmx/flutter-quill/pull/1230#issuecomment-1560597099) + ## 0.3.2 * Updated dependencies to support intl 0.18 diff --git a/flutter_quill_extensions/lib/embeds/builders.dart b/flutter_quill_extensions/lib/embeds/builders.dart index cf04a462..b16b5845 100644 --- a/flutter_quill_extensions/lib/embeds/builders.dart +++ b/flutter_quill_extensions/lib/embeds/builders.dart @@ -28,6 +28,7 @@ class ImageEmbedBuilder extends EmbedBuilder { base.Embed node, bool readOnly, bool inline, + TextStyle textStyle, ) { assert(!kIsWeb, 'Please provide image EmbedBuilder for Web'); @@ -164,6 +165,7 @@ class ImageEmbedBuilderWeb extends EmbedBuilder { Embed node, bool readOnly, bool inline, + TextStyle textStyle, ) { final imageUrl = node.value.data; @@ -198,6 +200,7 @@ class VideoEmbedBuilder extends EmbedBuilder { base.Embed node, bool readOnly, bool inline, + TextStyle textStyle, ) { assert(!kIsWeb, 'Please provide video EmbedBuilder for Web'); @@ -226,6 +229,7 @@ class FormulaEmbedBuilder extends EmbedBuilder { base.Embed node, bool readOnly, bool inline, + TextStyle textStyle, ) { assert(!kIsWeb, 'Please provide formula EmbedBuilder for Web'); diff --git a/flutter_quill_extensions/pubspec.yaml b/flutter_quill_extensions/pubspec.yaml index d57cd8bf..a1ce333f 100644 --- a/flutter_quill_extensions/pubspec.yaml +++ b/flutter_quill_extensions/pubspec.yaml @@ -1,6 +1,6 @@ name: flutter_quill_extensions description: Embed extensions for flutter_quill including image, video, formula and etc. -version: 0.3.2 +version: 0.3.3 homepage: https://bulletjournal.us/home/index.html repository: https://github.com/singerdmx/flutter-quill/tree/master/flutter_quill_extensions @@ -12,7 +12,7 @@ dependencies: flutter: sdk: flutter - flutter_quill: ^7.1.17 + flutter_quill: ^7.1.20 image_picker: ^0.8.5+3 photo_view: ^0.14.0