From c7dcbd2b726b54293dbaa0c08defae13b7f8088e Mon Sep 17 00:00:00 2001 From: X Code Date: Thu, 6 Jan 2022 09:32:08 -0800 Subject: [PATCH] Update RenderContentProxyBox double get preferredLineHeight --- lib/src/widgets/box.dart | 10 +++++++++- lib/src/widgets/proxy.dart | 8 ++------ lib/src/widgets/text_line.dart | 2 +- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/lib/src/widgets/box.dart b/lib/src/widgets/box.dart index b754b5c2..ad188c90 100644 --- a/lib/src/widgets/box.dart +++ b/lib/src/widgets/box.dart @@ -2,8 +2,16 @@ import 'package:flutter/rendering.dart'; import '../models/documents/nodes/container.dart'; +/// A common interface to render boxes which represent a piece of rich text +/// content. +/// +/// See also: +/// * [RenderParagraphProxy] implementation of this interface which wraps +/// built-in [RenderParagraph] +/// * [RenderEmbedProxy] implementation of this interface which wraps +/// an arbitrary render box representing an embeddable object. abstract class RenderContentProxyBox implements RenderBox { - double getPreferredLineHeight(); + double get preferredLineHeight; Offset getOffsetForCaret(TextPosition position, Rect? caretPrototype); diff --git a/lib/src/widgets/proxy.dart b/lib/src/widgets/proxy.dart index b9f683e1..0e05fb2e 100644 --- a/lib/src/widgets/proxy.dart +++ b/lib/src/widgets/proxy.dart @@ -123,9 +123,7 @@ class RenderEmbedProxy extends RenderProxyBox implements RenderContentProxyBox { const TextRange(start: 0, end: 1); @override - double getPreferredLineHeight() { - return size.height; - } + double get preferredLineHeight => size.height; } class RichTextProxy extends SingleChildRenderObjectWidget { @@ -274,9 +272,7 @@ class RenderParagraphProxy extends RenderProxyBox RenderParagraph? get child => super.child as RenderParagraph?; @override - double getPreferredLineHeight() { - return _prototypePainter.preferredLineHeight; - } + double get preferredLineHeight => _prototypePainter.preferredLineHeight; @override Offset getOffsetForCaret(TextPosition position, Rect? caretPrototype) => diff --git a/lib/src/widgets/text_line.dart b/lib/src/widgets/text_line.dart index db0fc973..f5138a7c 100644 --- a/lib/src/widgets/text_line.dart +++ b/lib/src/widgets/text_line.dart @@ -835,7 +835,7 @@ class RenderEditableTextLine extends RenderEditableBox { @override double preferredLineHeight(TextPosition position) { - return _body!.getPreferredLineHeight(); + return _body!.preferredLineHeight; } @override