Fixes for before_push script

pull/1829/head
Douglas Ward 1 year ago
parent 7419af62a0
commit b79379633c
  1. 36
      example/lib/screens/quill/my_quill_toolbar.dart
  2. 4
      lib/src/widgets/toolbar/base_button/base_value_button.dart
  3. 19
      lib/src/widgets/toolbar/buttons/font_family_button.dart
  4. 7
      lib/src/widgets/toolbar/buttons/font_size_button.dart
  5. 1
      lib/src/widgets/toolbar/buttons/toggle_check_list_button.dart
  6. 41
      lib/src/widgets/toolbar/buttons/toggle_style_button.dart

@ -223,24 +223,24 @@ class MyQuillToolbar extends StatelessWidget {
'40': '40.0' '40': '40.0'
}, },
// headerStyleType: HeaderStyleType.buttons, // headerStyleType: HeaderStyleType.buttons,
buttonOptions: QuillSimpleToolbarButtonOptions( // buttonOptions: QuillSimpleToolbarButtonOptions(
base: QuillToolbarBaseButtonOptions( // base: QuillToolbarBaseButtonOptions(
afterButtonPressed: focusNode.requestFocus, // afterButtonPressed: focusNode.requestFocus,
// // iconSize: 20, // // iconSize: 20,
// iconTheme: QuillIconTheme( // iconTheme: QuillIconTheme(
// iconButtonSelectedData: IconButtonData( // iconButtonSelectedData: IconButtonData(
// style: IconButton.styleFrom( // style: IconButton.styleFrom(
// foregroundColor: Colors.blue, // foregroundColor: Colors.blue,
// ), // ),
// ), // ),
// iconButtonUnselectedData: IconButtonData( // iconButtonUnselectedData: IconButtonData(
// style: IconButton.styleFrom( // style: IconButton.styleFrom(
// foregroundColor: Colors.red, // foregroundColor: Colors.red,
// ), // ),
// ), // ),
// ), // ),
), // ),
), //),
customButtons: [ customButtons: [
QuillToolbarCustomButtonOptions( QuillToolbarCustomButtonOptions(
icon: const Icon(Icons.add_alarm_rounded), icon: const Icon(Icons.add_alarm_rounded),

@ -21,7 +21,7 @@ abstract class QuillToolbarBaseValueButtonState<
W extends QuillToolbarBaseValueButton<T, E>, W extends QuillToolbarBaseValueButton<T, E>,
T extends QuillToolbarBaseButtonOptions<T, E>, T extends QuillToolbarBaseButtonOptions<T, E>,
E extends QuillToolbarBaseButtonExtraOptions, E extends QuillToolbarBaseButtonExtraOptions,
V > extends State<W> { V> extends State<W> {
T get options => widget.options; T get options => widget.options;
QuillController get controller => widget.controller; QuillController get controller => widget.controller;
@ -72,7 +72,7 @@ abstract class QuillToolbarBaseValueButtonState<
} }
double get iconSize { double get iconSize {
final baseFontSize = context.quillToolbarBaseButtonOptions?.iconSize; final baseFontSize = baseButtonExtraOptions?.iconSize;
final iconSize = options.iconSize; final iconSize = options.iconSize;
return iconSize ?? baseFontSize ?? kDefaultIconSize; return iconSize ?? baseFontSize ?? kDefaultIconSize;
} }

@ -28,16 +28,19 @@ class QuillToolbarFontFamilyButton extends QuillToolbarBaseValueButton<
QuillToolbarFontFamilyButtonState(); QuillToolbarFontFamilyButtonState();
} }
class QuillToolbarFontFamilyButtonState extends QuillToolbarBaseValueButtonState< class QuillToolbarFontFamilyButtonState
QuillToolbarFontFamilyButton, extends QuillToolbarBaseValueButtonState<
QuillToolbarFontFamilyButtonOptions, QuillToolbarFontFamilyButton,
QuillToolbarFontFamilyButtonExtraOptions, QuillToolbarFontFamilyButtonOptions,
String> { QuillToolbarFontFamilyButtonExtraOptions,
String> {
@override @override
String get currentStateValue { String get currentStateValue {
final attribute = controller.getSelectionStyle().attributes[options.attribute.key]; final attribute =
return attribute == null ? _defaultDisplayText : (_getKeyName(attribute.value) ?? _defaultDisplayText); controller.getSelectionStyle().attributes[options.attribute.key];
return attribute == null
? _defaultDisplayText
: (_getKeyName(attribute.value) ?? _defaultDisplayText);
} }
String get _defaultDisplayText { String get _defaultDisplayText {

@ -66,8 +66,11 @@ class QuillToolbarFontSizeButtonState extends QuillToolbarBaseValueButtonState<
@override @override
String get currentStateValue { String get currentStateValue {
final attribute = controller.getSelectionStyle().attributes[options.attribute.key]; final attribute =
return attribute == null ? _defaultDisplayText : (_getKeyName(attribute.value) ?? _defaultDisplayText); controller.getSelectionStyle().attributes[options.attribute.key];
return attribute == null
? _defaultDisplayText
: (_getKeyName(attribute.value) ?? _defaultDisplayText);
} }
String? _getKeyName(dynamic value) { String? _getKeyName(dynamic value) {

@ -27,7 +27,6 @@ class QuillToolbarToggleCheckListButtonState
QuillToolbarToggleCheckListButtonOptions, QuillToolbarToggleCheckListButtonOptions,
QuillToolbarToggleCheckListButtonExtraOptions, QuillToolbarToggleCheckListButtonExtraOptions,
bool> { bool> {
Style get _selectionStyle => controller.getSelectionStyle(); Style get _selectionStyle => controller.getSelectionStyle();
@override @override

@ -21,9 +21,7 @@ typedef ToggleStyleButtonBuilder = Widget Function(
QuillIconTheme? iconTheme, QuillIconTheme? iconTheme,
]); ]);
class QuillToolbarToggleStyleButton extends QuillToolbarBaseValueButton< class QuillToolbarToggleStyleButton extends QuillToolbarBaseValueButton<QuillToolbarToggleStyleButtonOptions, QuillToolbarToggleStyleButtonExtraOptions> {
QuillToolbarToggleStyleButtonOptions,
QuillToolbarToggleStyleButtonExtraOptions> {
const QuillToolbarToggleStyleButton({ const QuillToolbarToggleStyleButton({
required super.controller, required super.controller,
required this.attribute, required this.attribute,
@ -34,16 +32,11 @@ class QuillToolbarToggleStyleButton extends QuillToolbarBaseValueButton<
final Attribute attribute; final Attribute attribute;
@override @override
QuillToolbarToggleStyleButtonState createState() => QuillToolbarToggleStyleButtonState createState() => QuillToolbarToggleStyleButtonState();
QuillToolbarToggleStyleButtonState();
} }
class QuillToolbarToggleStyleButtonState extends QuillToolbarBaseValueButtonState< class QuillToolbarToggleStyleButtonState
QuillToolbarToggleStyleButton, extends QuillToolbarBaseValueButtonState<QuillToolbarToggleStyleButton, QuillToolbarToggleStyleButtonOptions, QuillToolbarToggleStyleButtonExtraOptions, bool> {
QuillToolbarToggleStyleButtonOptions,
QuillToolbarToggleStyleButtonExtraOptions,
bool> {
Style get _selectionStyle => controller.getSelectionStyle(); Style get _selectionStyle => controller.getSelectionStyle();
@override @override
@ -84,10 +77,7 @@ class QuillToolbarToggleStyleButtonState extends QuillToolbarBaseValueButtonStat
'left' => (context.loc.alignLeft, Icons.format_align_left), 'left' => (context.loc.alignLeft, Icons.format_align_left),
'right' => (context.loc.alignRight, Icons.format_align_right), 'right' => (context.loc.alignRight, Icons.format_align_right),
'center' => (context.loc.alignCenter, Icons.format_align_center), 'center' => (context.loc.alignCenter, Icons.format_align_center),
'justify' => ( 'justify' => (context.loc.justifyWinWidth, Icons.format_align_justify),
context.loc.justifyWinWidth,
Icons.format_align_justify
),
Object() => throw ArgumentError(widget.attribute.value), Object() => throw ArgumentError(widget.attribute.value),
null => (context.loc.alignCenter, Icons.format_align_center), null => (context.loc.alignCenter, Icons.format_align_center),
}; };
@ -103,9 +93,7 @@ class QuillToolbarToggleStyleButtonState extends QuillToolbarBaseValueButtonStat
String get defaultTooltip => _defaultTooltipAndIconData.$1; String get defaultTooltip => _defaultTooltipAndIconData.$1;
IconData get iconData { IconData get iconData {
return options.iconData ?? return options.iconData ?? context.quillToolbarBaseButtonOptions?.iconData ?? _defaultTooltipAndIconData.$2;
context.quillToolbarBaseButtonOptions?.iconData ??
_defaultTooltipAndIconData.$2;
} }
void _onPressed() { void _onPressed() {
@ -115,8 +103,7 @@ class QuillToolbarToggleStyleButtonState extends QuillToolbarBaseValueButtonStat
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
final childBuilder = options.childBuilder ?? final childBuilder = options.childBuilder ?? context.quillToolbarBaseButtonOptions?.childBuilder;
context.quillToolbarBaseButtonOptions?.childBuilder;
if (childBuilder != null) { if (childBuilder != null) {
return childBuilder( return childBuilder(
options, options,
@ -146,9 +133,7 @@ class QuillToolbarToggleStyleButtonState extends QuillToolbarBaseValueButtonStat
} }
bool _getIsToggled(Map<String, Attribute> attrs) { bool _getIsToggled(Map<String, Attribute> attrs) {
if (widget.attribute.key == Attribute.list.key || if (widget.attribute.key == Attribute.list.key || widget.attribute.key == Attribute.script.key || widget.attribute.key == Attribute.align.key) {
widget.attribute.key == Attribute.script.key ||
widget.attribute.key == Attribute.align.key) {
final attribute = attrs[widget.attribute.key]; final attribute = attrs[widget.attribute.key];
if (attribute == null) { if (attribute == null) {
return false; return false;
@ -159,11 +144,11 @@ class QuillToolbarToggleStyleButtonState extends QuillToolbarBaseValueButtonStat
} }
void _toggleAttribute() { void _toggleAttribute() {
controller..formatSelection( controller
currentValue ..skipRequestKeyboard = !widget.attribute.isInline
? Attribute.clone(widget.attribute, null) ..formatSelection(
: widget.attribute, currentValue ? Attribute.clone(widget.attribute, null) : widget.attribute,
) )
..selectStyle(widget.attribute, currentValue); ..selectStyle(widget.attribute, currentValue);
} }
} }

Loading…
Cancel
Save