From b66f8167b3b8607059632a1ad9c7fea052b3756b Mon Sep 17 00:00:00 2001 From: CatHood0 Date: Fri, 28 Jun 2024 14:51:33 -0400 Subject: [PATCH] removed print calls and fix no expect in test --- lib/src/packages/quill_markdown/markdown_to_delta.dart | 7 ------- lib/src/utils/html2md_utils.dart | 10 +++++----- test/utils/delta_x_test.dart | 7 ++++++- 3 files changed, 11 insertions(+), 13 deletions(-) diff --git a/lib/src/packages/quill_markdown/markdown_to_delta.dart b/lib/src/packages/quill_markdown/markdown_to_delta.dart index 2fd0dc39..c6870e96 100644 --- a/lib/src/packages/quill_markdown/markdown_to_delta.dart +++ b/lib/src/packages/quill_markdown/markdown_to_delta.dart @@ -1,6 +1,5 @@ import 'dart:collection'; import 'dart:convert'; -import 'dart:math'; import 'package:collection/collection.dart'; import 'package:markdown/markdown.dart' as md; @@ -125,7 +124,6 @@ class MarkdownToDelta extends Converter _topLevelNodes.addAll(mdNodes); for (final node in mdNodes) { - print(node.toString()); node.accept(this); } @@ -178,8 +176,6 @@ class MarkdownToDelta extends Converter @override bool visitElementBefore(md.Element element) { - print( - 'Visit before: [tag: ${element.tag}, attributes: ${element.attributes}]'); _insertNewLineBeforeElementIfNeeded(element); final tag = element.tag; @@ -212,9 +208,6 @@ class MarkdownToDelta extends Converter void visitElementAfter(md.Element element) { final tag = element.tag; - print( - 'Visit after: [tag: ${element.tag}, attributes: ${element.attributes}]'); - if (_isEmbedElement(element)) { _delta.insert(_toEmbeddable(element).toJson()); } diff --git a/lib/src/utils/html2md_utils.dart b/lib/src/utils/html2md_utils.dart index 8f72de2f..fdc92870 100644 --- a/lib/src/utils/html2md_utils.dart +++ b/lib/src/utils/html2md_utils.dart @@ -6,6 +6,11 @@ import 'package:markdown/src/ast.dart' as ast; import 'package:markdown/src/util.dart' as util; import 'package:meta/meta.dart'; +// [ character +const int $lbracket = 0x5B; +final RegExp youtubeVideoUrlValidator = RegExp( + r'^(?:https?:)?(?:\/\/)?(?:youtu\.be\/|(?:www\.|m\.)?youtube\.com\/(?:watch|v|embed)(?:\.php)?(?:\?.*v=|\/))([a-zA-Z0-9\_-]{7,15})(?:[\?&][a-zA-Z0-9\_-]+=[a-zA-Z0-9\_-]+)*(?:[&\/\#].*)?$'); + ///Local syntax implementation for underline class UnderlineSyntax extends md.DelimiterSyntax { UnderlineSyntax() @@ -17,11 +22,6 @@ class UnderlineSyntax extends md.DelimiterSyntax { ); } -// [ character -const int $lbracket = 0x5B; -final RegExp youtubeVideoUrlValidator = RegExp( - r'^(?:https?:)?(?:\/\/)?(?:youtu\.be\/|(?:www\.|m\.)?youtube\.com\/(?:watch|v|embed)(?:\.php)?(?:\?.*v=|\/))([a-zA-Z0-9\_-]{7,15})(?:[\?&][a-zA-Z0-9\_-]+=[a-zA-Z0-9\_-]+)*(?:[&\/\#].*)?$'); - class VideoSyntax extends md.LinkSyntax { VideoSyntax({super.linkResolver}) : super( diff --git a/test/utils/delta_x_test.dart b/test/utils/delta_x_test.dart index 4ce0dd4b..092fc838 100644 --- a/test/utils/delta_x_test.dart +++ b/test/utils/delta_x_test.dart @@ -25,6 +25,11 @@ void main() { Operation.insert('\n'), ]); + final expectedDeltaVideo = Delta.fromOperations([ + Operation.insert({'video': 'https://www.youtube.com/embed/dQw4w9WgXcQ'}), + Operation.insert('\n'), + ]); + test('should detect emphasis and parse correctly', () { final delta = DeltaX.fromHtml(htmlWithEmp); expect(delta, expectedDeltaEmp); @@ -37,6 +42,6 @@ void main() { test('should detect video and parse correctly', () { final delta = DeltaX.fromHtml(htmlWithVideo); - print(delta); + expect(delta, expectedDeltaVideo); }); }