Update todo

pull/1428/head
Ahmed Hnewa 2 years ago
parent 91d9906584
commit b29319edfe
No known key found for this signature in database
GPG Key ID: C488CC70BBCEF0D1
  1. 15
      flutter_quill_extensions/lib/embeds/builders.dart
  2. 14
      lib/src/utils/string.dart

@ -232,16 +232,11 @@ class ImageEmbedBuilder extends EmbedBuilder {
return sb.toString(); return sb.toString();
} }
// TODO: Please consider add bool // TODO: When update flutter_quill
// property in // we should update flutter_quill_extensions
// replaceStyleString that will use either // to use the latest version and use
// mobileWidth or width based on that // base.replaceStyleStringWithSize()
// property // instead of replaceStyleString
// but that require changes to the
// flutter_quill
// and it should be
// published and then we can
// change it from flutter_quill_extensions
final attr = base.isMobile() final attr = base.isMobile()
? base.replaceStyleString( ? base.replaceStyleString(

@ -19,6 +19,20 @@ Map<String, String> parseKeyValuePairs(String s, Set<String> targetKeys) {
return result; return result;
} }
@Deprecated('Use replaceStyleStringWithSize instead')
String replaceStyleString(
String s,
double width,
double height,
) {
return replaceStyleStringWithSize(
s,
width: width,
height: height,
isMobile: true,
);
}
String replaceStyleStringWithSize( String replaceStyleStringWithSize(
String s, { String s, {
required double width, required double width,

Loading…
Cancel
Save