From abd80f59469c7873691b48fcdcc12a71fe992e13 Mon Sep 17 00:00:00 2001 From: zhaoce Date: Thu, 10 Jun 2021 18:37:18 +0800 Subject: [PATCH] merge master into dev (#263) * Update issue templates * Updating checkbox to handle tap (#186) * updating checkbox to handle tap * updating checkbox to handle long press and using UniqueKey() to avoid weird side effects * removed useless doc Co-authored-by: Kevin Despoulains * Simple viewer (#187) * 2021-04-25 * 2021-04-26 * Fix simple viewer compilation error * Upgrade version - checkbox supports tapping * 171: support for non-scrollable text editor (#188) Co-authored-by: Gyuri Majercsik * custom rules & optionally auto add newline for image embeds (#205) * Adding missing overrides to make package work with Flutter 2.2.0 (#226) * Improve SOC of raw editor (#227) Improve separation of concerns for RawEditor by moving the code for the text input client to a separate class, furthermore add more comments. * Upgrade version * Improve SOC of raw editor (#228) Improve separation of concerns for `RawEditor` by moving the code for the keyboard to a separate class, furthermore add more comments. The PR does not change the functionality of the code. * Improve further SOC of raw editor This improves separation of concerns for the RawEditor by moving the code for the text selection delegate to a separate class, furthermore add more comments. The PR does not change the functionality of the code. * Hide implementation files (#233) * Fixes for flutter web (#234) * Fix for Attribute object comparison * Fix for "Unexpected null value" error on web Clipboard is now supported on web, via a permission request through the browser Co-authored-by: George Johnson * Dispose ValueNotifier of cursor controller * Remove getter for final operator A getter for a final variable makes no sense, because the variable cannot be reassigned. It is better to remove the unnecessary getter and make the variable public. * Add comments to cursor class * Remove null exception when a disposed controller is set * Disallow lines longer than 80 characters * Don't create a lambda when a tear-off will do * Move ResponsiveWidgets to example folder This widget has nothing to do with the library and is only used in the example, so it is moved to the example. * Fix null exception * Remove exception when widget is not mounted * Fix exception when rect is not a number * Fix paste (#236) closes #235. * Fix exception * Add const types for image and divider embeds This allows to reference the type. * Fix relative path * Add new logo * Fix buttons which ignore toolbariconsize Closes #189. * Upgrade to 1.3.1 * Fix incorrect double to int cast, and guard against optional parent (#239) * use ceil instead of floor to make sure won't cause overflow * Fix example project Podfile (#241) * Show arrow indicator on toolbar (#245) * Add color parameter to Toolbar and ImageButton In addition, change these widgets to stateless widgets, since these widgets do not have a state and thus stateful is superfluous. * Fix paste bug * Remove extraneous toolbar dividers in certain configuration Closes #193. * Upgrade version to 1.3.2 * Format code * Bump file_picker to 3.0.2+2 With version 3.0.2 `name` of the file_picker library becomes non-nullable, so a warning was issued for users who had already used version 3.0.2, as we still assumed that `name` is nullable. Increasing the version and removing the exclamation mark removes the warning. * Fix a bug that Embed could be together with Text (#249) * Fix #242 (#254) * Upgrade to 1.3.3 * Format code Co-authored-by: Xin Yao Co-authored-by: kevinDespoulains <46108869+kevinDespoulains@users.noreply.github.com> Co-authored-by: Kevin Despoulains Co-authored-by: em6m6e <50019687+em6m6e@users.noreply.github.com> Co-authored-by: Gyuri Majercsik Co-authored-by: Gyuri Majercsik Co-authored-by: hyouuu Co-authored-by: Till Friebe Co-authored-by: George Co-authored-by: George Johnson Co-authored-by: Ben Chung <1330575+yzxben@users.noreply.github.com> Co-authored-by: lucasbstn <64323294+lucasbstn@users.noreply.github.com> --- lib/src/widgets/keyboard_listener.dart | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/src/widgets/keyboard_listener.dart b/lib/src/widgets/keyboard_listener.dart index 59858d62..58df1725 100644 --- a/lib/src/widgets/keyboard_listener.dart +++ b/lib/src/widgets/keyboard_listener.dart @@ -1,6 +1,5 @@ import 'package:flutter/foundation.dart'; import 'package:flutter/services.dart'; -import 'package:flutter/widgets.dart'; enum InputShortcut { CUT, COPY, PASTE, SELECT_ALL } @@ -63,14 +62,14 @@ class KeyboardListener { LogicalKeyboardKey.keyA: InputShortcut.SELECT_ALL, }; - KeyEventResult handleRawKeyEvent(RawKeyEvent event) { + bool handleRawKeyEvent(RawKeyEvent event) { if (kIsWeb) { - // On web platform, we should ignore the key because it's processed already. - return KeyEventResult.ignored; + // On web platform, we ignore the key because it's already processed. + return false; } if (event is! RawKeyDownEvent) { - return KeyEventResult.ignored; + return false; } final keysPressed = @@ -83,7 +82,7 @@ class KeyboardListener { .length > 1 || keysPressed.difference(_interestingKeys).isNotEmpty) { - return KeyEventResult.ignored; + return false; } if (_moveKeys.contains(key)) { @@ -101,6 +100,6 @@ class KeyboardListener { } else if (key == LogicalKeyboardKey.backspace) { onDelete(false); } - return KeyEventResult.ignored; + return false; } }