From 9d6681ed2b3734bec56c8e763953de004c3e4ce8 Mon Sep 17 00:00:00 2001 From: X Code Date: Mon, 27 Dec 2021 11:16:30 -0800 Subject: [PATCH] Update constructor of EditorTextSelectionOverlay --- lib/src/widgets/raw_editor.dart | 24 ++++++++++-------------- lib/src/widgets/text_selection.dart | 28 ++++++++++++++-------------- 2 files changed, 24 insertions(+), 28 deletions(-) diff --git a/lib/src/widgets/raw_editor.dart b/lib/src/widgets/raw_editor.dart index 6374beef..006b6989 100644 --- a/lib/src/widgets/raw_editor.dart +++ b/lib/src/widgets/raw_editor.dart @@ -4,7 +4,6 @@ import 'dart:math' as math; import 'package:flutter/cupertino.dart'; import 'package:flutter/foundation.dart'; -import 'package:flutter/gestures.dart'; import 'package:flutter/material.dart'; import 'package:flutter/rendering.dart'; import 'package:flutter/scheduler.dart'; @@ -588,19 +587,16 @@ class RawEditorState extends EditorState _selectionOverlay = null; _selectionOverlay = EditorTextSelectionOverlay( - textEditingValue, - false, - context, - widget, - _toolbarLayerLink, - _startHandleLayerLink, - _endHandleLayerLink, - getRenderEditor(), - widget.selectionCtrls, - this, - DragStartBehavior.start, - null, - _clipboardStatus, + value: textEditingValue, + context: context, + debugRequiredFor: widget, + toolbarLayerLink: _toolbarLayerLink, + startHandleLayerLink: _startHandleLayerLink, + endHandleLayerLink: _endHandleLayerLink, + renderObject: getRenderEditor(), + selectionCtrls: widget.selectionCtrls, + selectionDelegate: this, + clipboardStatus: _clipboardStatus, ); _selectionOverlay!.handlesVisible = _shouldShowSelectionHandles(); _selectionOverlay!.showHandles(); diff --git a/lib/src/widgets/text_selection.dart b/lib/src/widgets/text_selection.dart index 35d5e059..d77ad93e 100644 --- a/lib/src/widgets/text_selection.dart +++ b/lib/src/widgets/text_selection.dart @@ -66,21 +66,21 @@ class EditorTextSelectionOverlay { /// Creates an object that manages overlay entries for selection handles. /// /// The [context] must not be null and must have an [Overlay] as an ancestor. - EditorTextSelectionOverlay( - this.value, - this.handlesVisible, - this.context, - this.debugRequiredFor, - this.toolbarLayerLink, - this.startHandleLayerLink, - this.endHandleLayerLink, - this.renderObject, - this.selectionCtrls, - this.selectionDelegate, - this.dragStartBehavior, + EditorTextSelectionOverlay({ + required this.value, + required this.context, + required this.toolbarLayerLink, + required this.startHandleLayerLink, + required this.endHandleLayerLink, + required this.renderObject, + required this.debugRequiredFor, + required this.selectionCtrls, + required this.selectionDelegate, + required this.clipboardStatus, this.onSelectionHandleTapped, - this.clipboardStatus, - ) { + this.dragStartBehavior = DragStartBehavior.start, + this.handlesVisible = false, + }) { final overlay = Overlay.of(context, rootOverlay: true)!; _toolbarController = AnimationController(