From 6722759441e995793d821bff3c448939459a783f Mon Sep 17 00:00:00 2001 From: Xin Yao Date: Thu, 25 Mar 2021 00:12:50 -0700 Subject: [PATCH] Clear warnings --- analysis_options.yaml | 4 +++- lib/models/documents/document.dart | 4 ++-- lib/models/documents/history.dart | 4 ++-- lib/widgets/controller.dart | 4 ++-- lib/widgets/delegate.dart | 22 +++++++++++----------- lib/widgets/editor.dart | 6 +++--- 6 files changed, 23 insertions(+), 21 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 98c97294..4679e597 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -2,4 +2,6 @@ include: package:pedantic/analysis_options.yaml analyzer: errors: - undefined_prefixed_name: ignore \ No newline at end of file + undefined_prefixed_name: ignore + omit_local_variable_types: ignore + unsafe_html: ignore \ No newline at end of file diff --git a/lib/models/documents/document.dart b/lib/models/documents/document.dart index 2e715f3f..d52e89a4 100644 --- a/lib/models/documents/document.dart +++ b/lib/models/documents/document.dart @@ -163,9 +163,9 @@ class Document { return _history.redo(this); } - get hasUndo => _history.hasUndo; + bool get hasUndo => _history.hasUndo; - get hasRedo => _history.hasRedo; + bool get hasRedo => _history.hasRedo; static Delta _transform(Delta delta) { Delta res = Delta(); diff --git a/lib/models/documents/history.dart b/lib/models/documents/history.dart index 99798d71..32e780c9 100644 --- a/lib/models/documents/history.dart +++ b/lib/models/documents/history.dart @@ -6,9 +6,9 @@ import 'document.dart'; class History { final HistoryStack stack = HistoryStack.empty(); - get hasUndo => stack.undo.isNotEmpty; + bool get hasUndo => stack.undo.isNotEmpty; - get hasRedo => stack.redo.isNotEmpty; + bool get hasRedo => stack.redo.isNotEmpty; /// used for disable redo or undo function bool ignoreChange; diff --git a/lib/widgets/controller.dart b/lib/widgets/controller.dart index 665211a9..d36a73b5 100644 --- a/lib/widgets/controller.dart +++ b/lib/widgets/controller.dart @@ -69,9 +69,9 @@ class QuillController extends ChangeNotifier { } } - get hasUndo => document.hasUndo; + bool get hasUndo => document.hasUndo; - get hasRedo => document.hasRedo; + bool get hasRedo => document.hasRedo; void replaceText(int index, int len, Object? data, TextSelection? textSelection) { assert(data is String || data is Embeddable); diff --git a/lib/widgets/delegate.dart b/lib/widgets/delegate.dart index 13cf999d..3cfb9cd6 100644 --- a/lib/widgets/delegate.dart +++ b/lib/widgets/delegate.dart @@ -31,7 +31,7 @@ class EditorTextSelectionGestureDetectorBuilder { return getEditor()!.getRenderEditor(); } - onTapDown(TapDownDetails details) { + void onTapDown(TapDownDetails details) { getRenderEditor()!.handleTapDown(details); PointerDeviceKind? kind = details.kind; @@ -40,7 +40,7 @@ class EditorTextSelectionGestureDetectorBuilder { kind == PointerDeviceKind.stylus; } - onForcePressStart(ForcePressDetails details) { + void onForcePressStart(ForcePressDetails details) { assert(delegate.getForcePressEnabled()); shouldShowSelectionToolbar = true; if (delegate.getSelectionEnabled()) { @@ -52,7 +52,7 @@ class EditorTextSelectionGestureDetectorBuilder { } } - onForcePressEnd(ForcePressDetails details) { + void onForcePressEnd(ForcePressDetails details) { assert(delegate.getForcePressEnabled()); getRenderEditor()!.selectWordsInRange( details.globalPosition, @@ -64,15 +64,15 @@ class EditorTextSelectionGestureDetectorBuilder { } } - onSingleTapUp(TapUpDetails details) { + void onSingleTapUp(TapUpDetails details) { if (delegate.getSelectionEnabled()) { getRenderEditor()!.selectWordEdge(SelectionChangedCause.tap); } } - onSingleTapCancel() {} + void onSingleTapCancel() {} - onSingleLongTapStart(LongPressStartDetails details) { + void onSingleLongTapStart(LongPressStartDetails details) { if (delegate.getSelectionEnabled()) { getRenderEditor()!.selectPositionAt( details.globalPosition, @@ -82,7 +82,7 @@ class EditorTextSelectionGestureDetectorBuilder { } } - onSingleLongTapMoveUpdate(LongPressMoveUpdateDetails details) { + void onSingleLongTapMoveUpdate(LongPressMoveUpdateDetails details) { if (delegate.getSelectionEnabled()) { getRenderEditor()!.selectPositionAt( details.globalPosition, @@ -92,13 +92,13 @@ class EditorTextSelectionGestureDetectorBuilder { } } - onSingleLongTapEnd(LongPressEndDetails details) { + void onSingleLongTapEnd(LongPressEndDetails details) { if (shouldShowSelectionToolbar) { getEditor()!.showToolbar(); } } - onDoubleTapDown(TapDownDetails details) { + void onDoubleTapDown(TapDownDetails details) { if (delegate.getSelectionEnabled()) { getRenderEditor()!.selectWord(SelectionChangedCause.tap); if (shouldShowSelectionToolbar) { @@ -107,7 +107,7 @@ class EditorTextSelectionGestureDetectorBuilder { } } - onDragSelectionStart(DragStartDetails details) { + void onDragSelectionStart(DragStartDetails details) { getRenderEditor()!.selectPositionAt( details.globalPosition, null, @@ -115,7 +115,7 @@ class EditorTextSelectionGestureDetectorBuilder { ); } - onDragSelectionUpdate( + void onDragSelectionUpdate( DragStartDetails startDetails, DragUpdateDetails updateDetails) { getRenderEditor()!.selectPositionAt( startDetails.globalPosition, diff --git a/lib/widgets/editor.dart b/lib/widgets/editor.dart index c939d5fe..305a58c8 100644 --- a/lib/widgets/editor.dart +++ b/lib/widgets/editor.dart @@ -325,7 +325,7 @@ class _QuillEditorState extends State return widget.enableInteractiveSelection; } - _requestKeyboard() { + void _requestKeyboard() { _editorKey.currentState!.requestKeyboard(); } } @@ -337,7 +337,7 @@ class _QuillEditorSelectionGestureDetectorBuilder _QuillEditorSelectionGestureDetectorBuilder(this._state) : super(_state); @override - onForcePressStart(ForcePressDetails details) { + void onForcePressStart(ForcePressDetails details) { super.onForcePressStart(details); if (delegate.getSelectionEnabled() && shouldShowSelectionToolbar) { getEditor()!.showToolbar(); @@ -345,7 +345,7 @@ class _QuillEditorSelectionGestureDetectorBuilder } @override - onForcePressEnd(ForcePressDetails details) {} + void onForcePressEnd(ForcePressDetails details) {} @override void onSingleLongTapMoveUpdate(LongPressMoveUpdateDetails details) {