171: support for non-scrollable text editor (#188)

Co-authored-by: Gyuri Majercsik <gyuri@fluttech.com>
pull/220/head
Gyuri Majercsik 4 years ago committed by GitHub
parent 387669e3ff
commit 5892e4c828
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      lib/widgets/editor.dart
  2. 5
      lib/widgets/raw_editor.dart

@ -1073,7 +1073,6 @@ class RenderEditableContainerBox extends RenderBox
@override @override
void performLayout() { void performLayout() {
assert(!constraints.hasBoundedHeight);
assert(constraints.hasBoundedWidth); assert(constraints.hasBoundedWidth);
_resolvePadding(); _resolvePadding();
assert(_resolvedPadding != null); assert(_resolvedPadding != null);

@ -994,9 +994,11 @@ class RawEditorState extends EditorState
_showCaretOnScreenScheduled = true; _showCaretOnScreenScheduled = true;
SchedulerBinding.instance!.addPostFrameCallback((_) { SchedulerBinding.instance!.addPostFrameCallback((_) {
if (widget.scrollable) {
_showCaretOnScreenScheduled = false; _showCaretOnScreenScheduled = false;
final viewport = RenderAbstractViewport.of(getRenderEditor())!; final viewport = RenderAbstractViewport.of(getRenderEditor());
final editorOffset = getRenderEditor()! final editorOffset = getRenderEditor()!
.localToGlobal(const Offset(0, 0), ancestor: viewport); .localToGlobal(const Offset(0, 0), ancestor: viewport);
final offsetInViewport = _scrollController!.offset + editorOffset.dy; final offsetInViewport = _scrollController!.offset + editorOffset.dy;
@ -1014,6 +1016,7 @@ class RawEditorState extends EditorState
curve: Curves.fastOutSlowIn, curve: Curves.fastOutSlowIn,
); );
} }
}
}); });
} }

Loading…
Cancel
Save