From 4bf7ae7fd48a6379763ffb1669edc65b6ff9ab82 Mon Sep 17 00:00:00 2001
From: Ellet <hello@freshplatform.net>
Date: Fri, 1 Dec 2023 07:52:08 +0300
Subject: [PATCH] fix: A bug in quill extensions

---
 .github/workflows/build.yml                   | 33 +++++++++++++++++++
 .github/workflows/main.yml                    |  6 ++--
 .pubignore                                    |  1 +
 flutter_quill_extensions/CHANGELOG.md         |  4 +++
 flutter_quill_extensions/README.md            |  2 ++
 .../toolbar/image_button/image_button.dart    | 13 +++++---
 .../image_button/select_image_source.dart     |  3 +-
 .../video_button/select_video_source.dart     |  1 +
 .../toolbar/video_button/video_button.dart    | 11 +++++--
 flutter_quill_extensions/pubspec.yaml         |  4 +--
 scripts/before-push.sh                        |  8 ++++-
 11 files changed, 72 insertions(+), 14 deletions(-)
 create mode 100644 .github/workflows/build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
new file mode 100644
index 00000000..221b2359
--- /dev/null
+++ b/.github/workflows/build.yml
@@ -0,0 +1,33 @@
+name: Build the example
+
+on:
+  pull_request:
+    branches: [master]
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+      - uses: subosito/flutter-action@v2
+        with:
+          channel: 'stable'
+          cache: true
+
+      - name: Check flutter version
+        run: flutter --version
+
+      - name: Install dependencies
+        run: flutter pub get
+      
+      - name: Flutter build Web
+        run: flutter build web --release --verbose --dart-define=CI=true
+        working-directory: ./example
+
+      - name: Install flutter Linux prerequisites
+        run: sudo apt-get install clang cmake git ninja-build pkg-config libgtk-3-dev liblzma-dev libstdc++-12-dev -y
+
+      - name: Flutter build Linux
+        run: flutter build linux --release --verbose --dart-define=CI=true
+        working-directory: ./example
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index aa72b67b..d76a2f45 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -47,9 +47,9 @@ jobs:
       - name: Run flutter tests
         run: flutter test
       
-      - name: Flutter build Web
-        run: flutter build web --release --verbose --dart-define=CI=true
-        working-directory: ./example
+      # - name: Flutter build Web
+      #   run: flutter build web --release --verbose --dart-define=CI=true
+      #   working-directory: ./example
 
       # - name: Install flutter Linux prerequisites
       #   run: sudo apt-get install clang cmake git ninja-build pkg-config libgtk-3-dev liblzma-dev libstdc++-12-dev -y
diff --git a/.pubignore b/.pubignore
index ffddfe1a..2ea8ae1e 100644
--- a/.pubignore
+++ b/.pubignore
@@ -9,6 +9,7 @@ pubspec_overrides.yaml.disabled
 example/.fvm/
 example/build/
 example/.dart_tool/
+example/assets/images/
 
 scripts/
 <!-- flutter_quill_extensions/
diff --git a/flutter_quill_extensions/CHANGELOG.md b/flutter_quill_extensions/CHANGELOG.md
index eb272c12..cd3ec636 100644
--- a/flutter_quill_extensions/CHANGELOG.md
+++ b/flutter_quill_extensions/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented in this file.
 
+## 0.7.2
+* Fix a bug when opening the link dialog for both video and image buttons
+* Update `README.md`
+
 ## 0.7.1
 * Update the minimum flutter version to `3.16.0`
 
diff --git a/flutter_quill_extensions/README.md b/flutter_quill_extensions/README.md
index 87f32dcc..c710f49e 100644
--- a/flutter_quill_extensions/README.md
+++ b/flutter_quill_extensions/README.md
@@ -246,6 +246,8 @@ OnDragDoneCallback get _onDragDone {
 - Handle different errors
 ```
 
+Please notice that the saving image functionality is not supported on Linux yet.
+
 ## Contributing
 
 We welcome contributions!
diff --git a/flutter_quill_extensions/lib/presentation/embeds/toolbar/image_button/image_button.dart b/flutter_quill_extensions/lib/presentation/embeds/toolbar/image_button/image_button.dart
index 08c323d2..552211b1 100644
--- a/flutter_quill_extensions/lib/presentation/embeds/toolbar/image_button/image_button.dart
+++ b/flutter_quill_extensions/lib/presentation/embeds/toolbar/image_button/image_button.dart
@@ -172,10 +172,15 @@ class QuillToolbarImageButton extends StatelessWidget {
   Future<String?> _typeLink(BuildContext context) async {
     final value = await showDialog<String>(
       context: context,
-      builder: (_) => TypeLinkDialog(
-        dialogTheme: options.dialogTheme,
-        linkRegExp: options.linkRegExp,
-        linkType: LinkType.image,
+      builder: (_) => QuillProvider.value(
+        value: context.requireQuillProvider,
+        child: FlutterQuillLocalizationsWidget(
+          child: TypeLinkDialog(
+            dialogTheme: options.dialogTheme,
+            linkRegExp: options.linkRegExp,
+            linkType: LinkType.image,
+          ),
+        ),
       ),
     );
     return value;
diff --git a/flutter_quill_extensions/lib/presentation/embeds/toolbar/image_button/select_image_source.dart b/flutter_quill_extensions/lib/presentation/embeds/toolbar/image_button/select_image_source.dart
index 5d1cf4b2..d40fd8f1 100644
--- a/flutter_quill_extensions/lib/presentation/embeds/toolbar/image_button/select_image_source.dart
+++ b/flutter_quill_extensions/lib/presentation/embeds/toolbar/image_button/select_image_source.dart
@@ -14,6 +14,7 @@ class SelectImageSourceDialog extends StatelessWidget {
       child: SingleChildScrollView(
         child: Column(
           children: [
+            // TODO: Needs to be translated
             ListTile(
               title: const Text('Gallery'),
               subtitle: const Text(
@@ -53,7 +54,7 @@ Future<InsertImageSource?> showSelectImageSourceDialog({
     showDragHandle: true,
     context: context,
     constraints: const BoxConstraints(maxWidth: 640),
-    builder: (context) => const SelectImageSourceDialog(),
+    builder: (_) => const SelectImageSourceDialog(),
   );
   return imageSource;
 }
diff --git a/flutter_quill_extensions/lib/presentation/embeds/toolbar/video_button/select_video_source.dart b/flutter_quill_extensions/lib/presentation/embeds/toolbar/video_button/select_video_source.dart
index 8e2d34d5..78fe6177 100644
--- a/flutter_quill_extensions/lib/presentation/embeds/toolbar/video_button/select_video_source.dart
+++ b/flutter_quill_extensions/lib/presentation/embeds/toolbar/video_button/select_video_source.dart
@@ -14,6 +14,7 @@ class SelectVideoSourceDialog extends StatelessWidget {
       child: SingleChildScrollView(
         child: Column(
           children: [
+            // TODO: Needs to be translated
             ListTile(
               title: const Text('Gallery'),
               subtitle: const Text(
diff --git a/flutter_quill_extensions/lib/presentation/embeds/toolbar/video_button/video_button.dart b/flutter_quill_extensions/lib/presentation/embeds/toolbar/video_button/video_button.dart
index 32b660f4..dd2fb8f5 100644
--- a/flutter_quill_extensions/lib/presentation/embeds/toolbar/video_button/video_button.dart
+++ b/flutter_quill_extensions/lib/presentation/embeds/toolbar/video_button/video_button.dart
@@ -164,9 +164,14 @@ class QuillToolbarVideoButton extends StatelessWidget {
   Future<String?> _typeLink(BuildContext context) async {
     final value = await showDialog<String>(
       context: context,
-      builder: (_) => TypeLinkDialog(
-        dialogTheme: options.dialogTheme,
-        linkType: LinkType.video,
+      builder: (_) => QuillProvider.value(
+        value: context.requireQuillProvider,
+        child: FlutterQuillLocalizationsWidget(
+          child: TypeLinkDialog(
+            dialogTheme: options.dialogTheme,
+            linkType: LinkType.video,
+          ),
+        ),
       ),
     );
     return value;
diff --git a/flutter_quill_extensions/pubspec.yaml b/flutter_quill_extensions/pubspec.yaml
index a347c160..428a13f3 100644
--- a/flutter_quill_extensions/pubspec.yaml
+++ b/flutter_quill_extensions/pubspec.yaml
@@ -1,6 +1,6 @@
 name: flutter_quill_extensions
 description: Embed extensions for flutter_quill including image, video, formula and etc.
-version: 0.7.1
+version: 0.7.2
 homepage: https://github.com/singerdmx/flutter-quill/tree/master/flutter_quill_extensions
 repository: https://github.com/singerdmx/flutter-quill/tree/master/flutter_quill_extensions
 
@@ -13,7 +13,7 @@ topics:
 platforms:
   android:
   ios:
-  # linux:
+  linux:
   macos:
   web:
   windows:
diff --git a/scripts/before-push.sh b/scripts/before-push.sh
index 3c163f6a..f5aac35c 100755
--- a/scripts/before-push.sh
+++ b/scripts/before-push.sh
@@ -21,7 +21,13 @@ echo "Running 'dart format .'"
 dart format .
 
 # Check dart code formatting
-echo "Running `dart format --set-exit-if-changed .`"
+echo "Running 'dart format --set-exit-if-changed .'"
 dart format --set-exit-if-changed .
 
+# Check flutter web example
+echo "Running flutter build web --release --dart-define=CI=true."
+(cd example && flutter build web --release --dart-define=CI=true)
+
+echo ""
+
 echo "Script completed."