Always put required named parameters first (#115)

pull/116/head^2
Till Friebe 4 years ago committed by GitHub
parent cd05dfaeb8
commit 25f1582f70
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      analysis_options.yaml
  2. 2
      lib/widgets/default_styles.dart
  3. 4
      lib/widgets/editor.dart
  4. 12
      lib/widgets/responsive_widget.dart
  5. 6
      lib/widgets/text_block.dart
  6. 17
      lib/widgets/text_line.dart
  7. 6
      lib/widgets/text_selection.dart
  8. 127
      lib/widgets/toolbar.dart

@ -7,5 +7,6 @@ analyzer:
unsafe_html: ignore unsafe_html: ignore
linter: linter:
rules: rules:
- always_put_required_named_parameters_first
- avoid_print - avoid_print
- avoid_redundant_argument_values - avoid_redundant_argument_values

@ -6,9 +6,9 @@ class QuillStyles extends InheritedWidget {
final DefaultStyles data; final DefaultStyles data;
QuillStyles({ QuillStyles({
Key? key,
required this.data, required this.data,
required Widget child, required Widget child,
Key? key,
}) : super(key: key, child: child); }) : super(key: key, child: child);
@override @override

@ -176,14 +176,14 @@ class QuillEditor extends StatefulWidget {
required this.scrollable, required this.scrollable,
required this.padding, required this.padding,
required this.autoFocus, required this.autoFocus,
this.showCursor,
required this.readOnly, required this.readOnly,
required this.expands,
this.showCursor,
this.placeholder, this.placeholder,
this.enableInteractiveSelection = true, this.enableInteractiveSelection = true,
this.minHeight, this.minHeight,
this.maxHeight, this.maxHeight,
this.customStyles, this.customStyles,
required this.expands,
this.textCapitalization = TextCapitalization.sentences, this.textCapitalization = TextCapitalization.sentences,
this.keyboardAppearance = Brightness.light, this.keyboardAppearance = Brightness.light,
this.scrollPhysics, this.scrollPhysics,

@ -5,12 +5,12 @@ class ResponsiveWidget extends StatelessWidget {
final Widget? mediumScreen; final Widget? mediumScreen;
final Widget? smallScreen; final Widget? smallScreen;
const ResponsiveWidget( const ResponsiveWidget({
{Key? key, required this.largeScreen,
required this.largeScreen, this.mediumScreen,
this.mediumScreen, this.smallScreen,
this.smallScreen}) Key? key,
: super(key: key); }) : super(key: key);
static bool isSmallScreen(BuildContext context) { static bool isSmallScreen(BuildContext context) {
return MediaQuery.of(context).size.width < 800; return MediaQuery.of(context).size.width < 800;

@ -253,11 +253,11 @@ class EditableTextBlock extends StatelessWidget {
class RenderEditableTextBlock extends RenderEditableContainerBox class RenderEditableTextBlock extends RenderEditableContainerBox
implements RenderEditableBox { implements RenderEditableBox {
RenderEditableTextBlock({ RenderEditableTextBlock({
List<RenderEditableBox>? children,
required Block block, required Block block,
required TextDirection textDirection, required TextDirection textDirection,
required EdgeInsetsGeometry padding, required EdgeInsetsGeometry padding,
required Decoration decoration, required Decoration decoration,
List<RenderEditableBox>? children,
ImageConfiguration configuration = ImageConfiguration.empty, ImageConfiguration configuration = ImageConfiguration.empty,
EdgeInsets contentPadding = EdgeInsets.zero, EdgeInsets contentPadding = EdgeInsets.zero,
}) : _decoration = decoration, }) : _decoration = decoration,
@ -558,7 +558,6 @@ class _NumberPoint extends StatelessWidget {
final double padding; final double padding;
const _NumberPoint({ const _NumberPoint({
Key? key,
required this.index, required this.index,
required this.indentLevelCounts, required this.indentLevelCounts,
required this.count, required this.count,
@ -567,6 +566,7 @@ class _NumberPoint extends StatelessWidget {
required this.attrs, required this.attrs,
this.withDot = true, this.withDot = true,
this.padding = 0.0, this.padding = 0.0,
Key? key,
}) : super(key: key); }) : super(key: key);
@override @override
@ -656,9 +656,9 @@ class _BulletPoint extends StatelessWidget {
final double width; final double width;
const _BulletPoint({ const _BulletPoint({
Key? key,
required this.style, required this.style,
required this.width, required this.width,
Key? key,
}) : super(key: key); }) : super(key: key);
@override @override

@ -27,13 +27,13 @@ class TextLine extends StatelessWidget {
final EmbedBuilder embedBuilder; final EmbedBuilder embedBuilder;
final DefaultStyles styles; final DefaultStyles styles;
const TextLine( const TextLine({
{Key? key, required this.line,
required this.line, required this.embedBuilder,
this.textDirection, required this.styles,
required this.embedBuilder, this.textDirection,
required this.styles}) Key? key,
: super(key: key); }) : super(key: key);
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
@ -839,7 +839,8 @@ class _TextLineElement extends RenderObjectElement {
} }
@override @override
void moveRenderObjectChild(RenderObject child, dynamic oldSlot, dynamic newSlot) { void moveRenderObjectChild(
RenderObject child, dynamic oldSlot, dynamic newSlot) {
throw UnimplementedError(); throw UnimplementedError();
} }

@ -245,7 +245,6 @@ class EditorTextSelectionOverlay {
class _TextSelectionHandleOverlay extends StatefulWidget { class _TextSelectionHandleOverlay extends StatefulWidget {
const _TextSelectionHandleOverlay({ const _TextSelectionHandleOverlay({
Key? key,
required this.selection, required this.selection,
required this.position, required this.position,
required this.startHandleLayerLink, required this.startHandleLayerLink,
@ -255,6 +254,7 @@ class _TextSelectionHandleOverlay extends StatefulWidget {
required this.onSelectionHandleTapped, required this.onSelectionHandleTapped,
required this.selectionControls, required this.selectionControls,
this.dragStartBehavior = DragStartBehavior.start, this.dragStartBehavior = DragStartBehavior.start,
Key? key,
}) : super(key: key); }) : super(key: key);
final TextSelection selection; final TextSelection selection;
@ -468,7 +468,7 @@ class _TextSelectionHandleOverlayState
class EditorTextSelectionGestureDetector extends StatefulWidget { class EditorTextSelectionGestureDetector extends StatefulWidget {
const EditorTextSelectionGestureDetector({ const EditorTextSelectionGestureDetector({
Key? key, required this.child,
this.onTapDown, this.onTapDown,
this.onForcePressStart, this.onForcePressStart,
this.onForcePressEnd, this.onForcePressEnd,
@ -482,7 +482,7 @@ class EditorTextSelectionGestureDetector extends StatefulWidget {
this.onDragSelectionUpdate, this.onDragSelectionUpdate,
this.onDragSelectionEnd, this.onDragSelectionEnd,
this.behavior, this.behavior,
required this.child, Key? key,
}) : super(key: key); }) : super(key: key);
final GestureTapDownCallback? onTapDown; final GestureTapDownCallback? onTapDown;

@ -25,9 +25,9 @@ class InsertEmbedButton extends StatelessWidget {
final IconData icon; final IconData icon;
const InsertEmbedButton({ const InsertEmbedButton({
Key? key,
required this.controller, required this.controller,
required this.icon, required this.icon,
Key? key,
}) : super(key: key); }) : super(key: key);
@override @override
@ -56,9 +56,9 @@ class LinkStyleButton extends StatefulWidget {
final IconData? icon; final IconData? icon;
const LinkStyleButton({ const LinkStyleButton({
Key? key,
required this.controller, required this.controller,
this.icon, this.icon,
Key? key,
}) : super(key: key); }) : super(key: key);
@override @override
@ -183,11 +183,11 @@ class ToggleStyleButton extends StatefulWidget {
final ToggleStyleButtonBuilder childBuilder; final ToggleStyleButtonBuilder childBuilder;
ToggleStyleButton({ ToggleStyleButton({
Key? key,
required this.attribute, required this.attribute,
required this.icon, required this.icon,
required this.controller, required this.controller,
this.childBuilder = defaultToggleStyleButtonBuilder, this.childBuilder = defaultToggleStyleButtonBuilder,
Key? key,
}) : super(key: key); }) : super(key: key);
@override @override
@ -267,11 +267,11 @@ class ToggleCheckListButton extends StatefulWidget {
final Attribute attribute; final Attribute attribute;
ToggleCheckListButton({ ToggleCheckListButton({
Key? key,
required this.icon, required this.icon,
required this.controller, required this.controller,
this.childBuilder = defaultToggleStyleButtonBuilder,
required this.attribute, required this.attribute,
this.childBuilder = defaultToggleStyleButtonBuilder,
Key? key,
}) : super(key: key); }) : super(key: key);
@override @override
@ -371,7 +371,7 @@ Widget defaultToggleStyleButtonBuilder(
class SelectHeaderStyleButton extends StatefulWidget { class SelectHeaderStyleButton extends StatefulWidget {
final QuillController controller; final QuillController controller;
const SelectHeaderStyleButton({Key? key, required this.controller}) const SelectHeaderStyleButton({required this.controller, Key? key})
: super(key: key); : super(key: key);
@override @override
@ -494,14 +494,14 @@ class ImageButton extends StatefulWidget {
final ImageSource imageSource; final ImageSource imageSource;
ImageButton( ImageButton({
{Key? key, required this.icon,
required this.icon, required this.controller,
required this.controller, required this.imageSource,
required this.imageSource, this.onImagePickCallback,
this.onImagePickCallback, this.imagePickImpl,
this.imagePickImpl}) Key? key,
: super(key: key); }) : super(key: key);
@override @override
_ImageButtonState createState() => _ImageButtonState(); _ImageButtonState createState() => _ImageButtonState();
@ -600,12 +600,12 @@ class ColorButton extends StatefulWidget {
final bool background; final bool background;
final QuillController controller; final QuillController controller;
ColorButton( ColorButton({
{Key? key, required this.icon,
required this.icon, required this.controller,
required this.controller, required this.background,
required this.background}) Key? key,
: super(key: key); }) : super(key: key);
@override @override
_ColorButtonState createState() => _ColorButtonState(); _ColorButtonState createState() => _ColorButtonState();
@ -738,12 +738,12 @@ class HistoryButton extends StatefulWidget {
final bool undo; final bool undo;
final QuillController controller; final QuillController controller;
HistoryButton( HistoryButton({
{Key? key, required this.icon,
required this.icon, required this.controller,
required this.controller, required this.undo,
required this.undo}) Key? key,
: super(key: key); }) : super(key: key);
@override @override
_HistoryButtonState createState() => _HistoryButtonState(); _HistoryButtonState createState() => _HistoryButtonState();
@ -810,12 +810,12 @@ class IndentButton extends StatefulWidget {
final QuillController controller; final QuillController controller;
final bool isIncrease; final bool isIncrease;
IndentButton( IndentButton({
{Key? key, required this.icon,
required this.icon, required this.controller,
required this.controller, required this.isIncrease,
required this.isIncrease}) Key? key,
: super(key: key); }) : super(key: key);
@override @override
_IndentButtonState createState() => _IndentButtonState(); _IndentButtonState createState() => _IndentButtonState();
@ -865,7 +865,7 @@ class ClearFormatButton extends StatefulWidget {
final QuillController controller; final QuillController controller;
ClearFormatButton({Key? key, required this.icon, required this.controller}) ClearFormatButton({required this.icon, required this.controller, Key? key})
: super(key: key); : super(key: key);
@override @override
@ -896,30 +896,31 @@ class _ClearFormatButtonState extends State<ClearFormatButton> {
class QuillToolbar extends StatefulWidget implements PreferredSizeWidget { class QuillToolbar extends StatefulWidget implements PreferredSizeWidget {
final List<Widget> children; final List<Widget> children;
const QuillToolbar({Key? key, required this.children}) : super(key: key); const QuillToolbar({required this.children, Key? key}) : super(key: key);
factory QuillToolbar.basic( factory QuillToolbar.basic({
{Key? key, required QuillController controller,
required QuillController controller, double toolbarIconSize = 18.0,
double toolbarIconSize = 18.0, bool showBoldButton = true,
bool showBoldButton = true, bool showItalicButton = true,
bool showItalicButton = true, bool showUnderLineButton = true,
bool showUnderLineButton = true, bool showStrikeThrough = true,
bool showStrikeThrough = true, bool showColorButton = true,
bool showColorButton = true, bool showBackgroundColorButton = true,
bool showBackgroundColorButton = true, bool showClearFormat = true,
bool showClearFormat = true, bool showHeaderStyle = true,
bool showHeaderStyle = true, bool showListNumbers = true,
bool showListNumbers = true, bool showListBullets = true,
bool showListBullets = true, bool showListCheck = true,
bool showListCheck = true, bool showCodeBlock = true,
bool showCodeBlock = true, bool showQuote = true,
bool showQuote = true, bool showIndent = true,
bool showIndent = true, bool showLink = true,
bool showLink = true, bool showHistory = true,
bool showHistory = true, bool showHorizontalRule = false,
bool showHorizontalRule = false, OnImagePickCallback? onImagePickCallback,
OnImagePickCallback? onImagePickCallback}) { Key? key,
}) {
iconSize = toolbarIconSize; iconSize = toolbarIconSize;
return QuillToolbar(key: key, children: [ return QuillToolbar(key: key, children: [
Visibility( Visibility(
@ -1146,13 +1147,13 @@ class QuillIconButton extends StatelessWidget {
final double highlightElevation; final double highlightElevation;
const QuillIconButton({ const QuillIconButton({
Key? key,
required this.onPressed, required this.onPressed,
this.icon, this.icon,
this.size = 40, this.size = 40,
this.fillColor, this.fillColor,
this.hoverElevation = 1, this.hoverElevation = 1,
this.highlightElevation = 1, this.highlightElevation = 1,
Key? key,
}) : super(key: key); }) : super(key: key);
@override @override
@ -1184,15 +1185,15 @@ class QuillDropdownButton<T> extends StatefulWidget {
final ValueChanged<T> onSelected; final ValueChanged<T> onSelected;
const QuillDropdownButton({ const QuillDropdownButton({
Key? key,
this.height = 40,
this.fillColor,
this.hoverElevation = 1,
this.highlightElevation = 1,
required this.child, required this.child,
required this.initialValue, required this.initialValue,
required this.items, required this.items,
required this.onSelected, required this.onSelected,
this.height = 40,
this.fillColor,
this.hoverElevation = 1,
this.highlightElevation = 1,
Key? key,
}) : super(key: key); }) : super(key: key);
@override @override

Loading…
Cancel
Save