From 15a2f1d76f7c81b62adca20ff5b9bfd13f0100be Mon Sep 17 00:00:00 2001 From: Till Friebe Date: Thu, 8 Apr 2021 20:20:09 +0200 Subject: [PATCH] Prefer const declarations Const declarations are more hot-reload friendly and allow to use const constructors if an instantiation references this declaration. --- analysis_options.yaml | 1 + lib/models/documents/style.dart | 2 +- lib/models/quill_delta.dart | 3 +-- lib/widgets/default_styles.dart | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 50b1b8fc..ac173063 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -13,6 +13,7 @@ linter: - omit_local_variable_types - prefer_const_constructors - prefer_const_constructors_in_immutables + - prefer_const_declarations - prefer_final_fields - prefer_final_in_for_each - prefer_final_locals diff --git a/lib/models/documents/style.dart b/lib/models/documents/style.dart index 4becc57e..37f6a0b9 100644 --- a/lib/models/documents/style.dart +++ b/lib/models/documents/style.dart @@ -95,7 +95,7 @@ class Style { return false; } final typedOther = other; - final eq = const MapEquality(); + const eq = MapEquality(); return eq.equals(_attributes, typedOther._attributes); } diff --git a/lib/models/quill_delta.dart b/lib/models/quill_delta.dart index c8707ee0..0135bd6a 100644 --- a/lib/models/quill_delta.dart +++ b/lib/models/quill_delta.dart @@ -293,8 +293,7 @@ class Delta { if (identical(this, other)) return true; if (other is! Delta) return false; final typedOther = other; - final comparator = - const ListEquality(DefaultEquality()); + const comparator = ListEquality(DefaultEquality()); return comparator.equals(_operations, typedOther._operations); } diff --git a/lib/widgets/default_styles.dart b/lib/widgets/default_styles.dart index 7f908114..2f2ea02c 100644 --- a/lib/widgets/default_styles.dart +++ b/lib/widgets/default_styles.dart @@ -90,7 +90,7 @@ class DefaultStyles { fontSize: 16.0, height: 1.3, ); - final baseSpacing = const Tuple2(6.0, 0); + const baseSpacing = Tuple2(6.0, 0); String fontFamily; switch (themeData.platform) { case TargetPlatform.iOS: